| commit | b1c771ab13b6c59cdb4cf9d46c3217b111916076 | |
| author | Henri Verroken <hverr@fb.com> | |
| Wed, 1 Sep 2021 15:04:59 +0000 (1 08:04 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 1 Sep 2021 15:26:41 +0000 (1 08:26 -0700) | ||
| tree | a8b44fb5280a1cab30db69a685661e05039fc5b1 | treesnapshot (tar.gz zip) |
| parent | 7379be839f4104c2c6ff4520a8484a3bcdf9deb7 | commitdiff |
Use direct decl parser to update naming table
Summary:
We should use the direct decl parser results for the naming phase.
The direct decl parser behaviour is different from the legacy parser: parser errors in the body might be ignored! As such, if we use the legacy parser result to update the naming table, we might erroneously remove entries! When typechecking files using that entry, erroneous "Name unbound" errors will be reported. Those are unrecoverable, because decl diffing won't catch any changes (the direct decl parser returns the same result with or without parsing errors), and no fanout will be computed.
Differential Revision: D30332172
fbshipit-source-id: d0cc8de0d460596b0f07b7bbdc986cedbdd23c00
Summary:
We should use the direct decl parser results for the naming phase.
The direct decl parser behaviour is different from the legacy parser: parser errors in the body might be ignored! As such, if we use the legacy parser result to update the naming table, we might erroneously remove entries! When typechecking files using that entry, erroneous "Name unbound" errors will be reported. Those are unrecoverable, because decl diffing won't catch any changes (the direct decl parser returns the same result with or without parsing errors), and no fanout will be computed.
Differential Revision: D30332172
fbshipit-source-id: d0cc8de0d460596b0f07b7bbdc986cedbdd23c00
12 files changed: