Ban assignment by reference in strict mode
commitae90ad76cac8800896dd2e1a6356bcc28ca200bd
authorDwayne Reeves <dreeves@fb.com>
Tue, 8 Mar 2016 19:11:02 +0000 (8 11:11 -0800)
committerHhvm Bot <hhvm-bot-bot@fb.com>
Tue, 8 Mar 2016 20:00:37 +0000 (8 12:00 -0800)
treeb2009815c83dd13977599137c092466fd3c3d97f
parent2d71f6dca3d9e1b46eacc2eebbd9f62acda8d33b
Ban assignment by reference in strict mode

Summary:References are supposed to be banned in Hack strict mode, but left a hole for assignment by reference.

This diff fills that hole by banning assignment by reference in strict files.

Reviewed By: int3

Differential Revision: D3014471

fb-gh-sync-id: 977c7ebfb2489c505a00c54973548bad84ff33ec
shipit-source-id: 977c7ebfb2489c505a00c54973548bad84ff33ec
hphp/hack/src/typing/typing.ml
hphp/hack/src/utils/errors.ml
hphp/hack/src/utils/errors.mli
hphp/hack/test/typecheck/references/strict_foreach_reference1.php [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_foreach_reference1.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_foreach_reference2.php [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_foreach_reference2.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_reference.php [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_reference.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_reference2.php [new file with mode: 0644]
hphp/hack/test/typecheck/references/strict_reference2.php.exp [new file with mode: 0644]