| commit | ae373782b4e92aade4d299a93da38109e8deb9e1 | |
| author | Alexey Toptygin <alexeyt@fb.com> | |
| Wed, 10 Jul 2019 00:43:42 +0000 (9 17:43 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 10 Jul 2019 02:55:49 +0000 (9 19:55 -0700) | ||
| tree | 0b81eb8213c463bd729cdc7c5a11a545c934b530 | treesnapshot (tar.gz zip) |
| parent | d25b60521af74f79bd5fa173721626a497841a59 | commitdiff |
Simplify string refcounting logic from D16099141
Summary: There's no need to manually incref the StringData and then use String::attach to skip refcounting when putting it in to a String, just use the normal String constructor that takes a StringData and have it handle it.
Reviewed By: yujunglo
Differential Revision: D16167907
fbshipit-source-id: 56a0f49d586fe3c5447bc33c7ccdf031695b19ec
Summary: There's no need to manually incref the StringData and then use String::attach to skip refcounting when putting it in to a String, just use the normal String constructor that takes a StringData and have it handle it.
Reviewed By: yujunglo
Differential Revision: D16167907
fbshipit-source-id: 56a0f49d586fe3c5447bc33c7ccdf031695b19ec
| hphp/runtime/ext/std/ext_std_classobj.cpp | diffblobblamehistory |