Audit every call site of `Provider_context.empty` and provide justification
commitac308dfe796c8dcec170b27aa3b5b9c95216f0af
authorWaleed Khan <waleedk@fb.com>
Mon, 10 Feb 2020 23:28:33 +0000 (10 15:28 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Mon, 10 Feb 2020 23:33:30 +0000 (10 15:33 -0800)
treebe79cfeb1543b5be5e0af86787d4bfdc9a789c57
parent7b7393a10aa03045da069c758e1f9cf162d7ceeb
Audit every call site of `Provider_context.empty` and provide justification

Summary: Creating a new context may drop the backend setting or local changes, which could lead to bugs. Audit every site of `Provider_context.empty` and replace them with more descriptive constructors, explaining why they're empty.

Reviewed By: ljw1004

Differential Revision: D19202207

fbshipit-source-id: 75c3fc7647371825f9fe6c45af29f2f683802cc4
22 files changed:
hphp/hack/src/client/ide_service/clientIdeDaemon.ml
hphp/hack/src/hh_single_decl.ml
hphp/hack/src/hh_single_type_check.ml
hphp/hack/src/providers/provider_backend.mli
hphp/hack/src/providers/provider_context.ml
hphp/hack/src/providers/provider_context.mli
hphp/hack/src/providers/provider_utils.ml
hphp/hack/src/server/cstSearchService.ml
hphp/hack/src/server/ffpAutocompleteService.ml
hphp/hack/src/server/ffpAutocompleteTypeCheck.ml
hphp/hack/src/server/serverAiInit.ml
hphp/hack/src/server/serverGlobalInference.ml
hphp/hack/src/server/serverRefactor.ml
hphp/hack/src/server/serverRpc.ml
hphp/hack/src/server/serverStatusSingle.ml
hphp/hack/src/typing/tast_env.ml
hphp/hack/src/typing/typing_check_service.ml
hphp/hack/src/typing/typing_log.ml
hphp/hack/test/integration/symbol_index_test.ml
hphp/hack/test/integration_ml/integration_test_base.ml
hphp/hack/test/unit/server_tests.ml
hphp/hack/test/unit/typing/typeSimplifierTest.ml