POST_INTERP_RET: use a direct helper rather than service request
commitac037244608e96b461b2d95cbc1ab95cbfa7cc88
authorJan Oravec <jan@fb.com>
Thu, 1 Apr 2021 18:06:39 +0000 (1 11:06 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 1 Apr 2021 18:08:21 +0000 (1 11:08 -0700)
tree7c5f1557e32565882d710a74f94ba8b3861df26d
parenta6e3f80ca5d957153cd9013302f864c236cc8cf1
POST_INTERP_RET: use a direct helper rather than service request

Summary:
There's no point in emitting a single service request stub inside unique stub
to multiplex the call just so that we can demultiplex it.

Eliminate all this unnecessary complexity and just call a direct C++ helper.

Move responsibilities for loading/storing various stuff between the unique stub
and the C++ helper to simplify both.

Reviewed By: ricklavoie

Differential Revision: D27496111

fbshipit-source-id: ad3f2db27798dadb1e57a250bba2eefda02a715c
hphp/runtime/vm/jit/service-request-handlers.cpp
hphp/runtime/vm/jit/service-request-handlers.h
hphp/runtime/vm/jit/service-requests.h
hphp/runtime/vm/jit/unique-stubs.cpp
hphp/runtime/vm/jit/unique-stubs.h