Throw inside HHVM for array_key_exists(null, $hack_array)
commitab5a10712d2a9d30d159932de931ed78f99d22d1
authorRodrigo Muñoz <rmk@fb.com>
Wed, 12 Feb 2020 00:50:05 +0000 (11 16:50 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 12 Feb 2020 00:52:34 +0000 (11 16:52 -0800)
tree84aee12902070cbcda5b1cc24b809871569145bf
parentad7c93fc0fb691313483029281f9510e43a8dabf
Throw inside HHVM for array_key_exists(null, $hack_array)

Summary: As part of unifying the behaviors between legacy PHP arrays and Hack arrays, we are ready to start enforcing against the use of `null` key checks against hack arrays.

Reviewed By: jjgriego

Differential Revision: D19731048

fbshipit-source-id: 4a1027bb84c690daf03544827c59513bd491e213
15 files changed:
hphp/hhbbc/interp.cpp
hphp/hhbbc/main.cpp
hphp/runtime/base/array-data-inl.h
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/runtime-option.h
hphp/runtime/ext/array/ext_array.cpp
hphp/runtime/vm/jit/irgen-builtin.cpp
hphp/test/quick/dict/basic-getters.php.expect
hphp/test/quick/keyset/basic-getters.php.expect
hphp/test/quick/vec/basic-getters.php.expect
hphp/test/slow/hack_arr_compat/array_key_exists_null/case.php
hphp/test/slow/hack_arr_compat/array_key_exists_null/case.php.expectf
hphp/test/slow/hack_arr_compat/array_key_exists_null/case.php.hphp_opts [deleted file]
hphp/test/slow/hack_arr_compat/array_key_exists_null/case.php.opts [deleted file]