| commit | ab3d02c7c2d9600eef7afabb1587179311e47db3 | |
| author | Mark Williams <mwilliams@fb.com> | |
| Mon, 15 Apr 2019 16:51:07 +0000 (15 09:51 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 15 Apr 2019 17:00:37 +0000 (15 10:00 -0700) | ||
| tree | c4ae4298769db0517eecc7013a5b4c0c29d51e1e | treesnapshot (tar.gz zip) |
| parent | 95a126169c6477ba5f61f6f89215c9e5bc5ead7c | commitdiff |
Use the default busy handler
Summary:
I experimented with various busy handler schemes. It was possible to
make it a little better, but it was always easy to trigger the "failed
to get lock" warning. The default busy handler's back off scheme seems
to be about as good as any, and the warning isn't really helpful - if
we're trying to write a unit, failure is ignored (we'll try again next
time we load the unit), and for other things, we'll report an error
anyway.
Reviewed By: ricklavoie, binliu19
Differential Revision: D14930670
fbshipit-source-id: b6a4efc2b17986492a799d1a77bf35b25c087f7b
Summary:
I experimented with various busy handler schemes. It was possible to
make it a little better, but it was always easy to trigger the "failed
to get lock" warning. The default busy handler's back off scheme seems
to be about as good as any, and the warning isn't really helpful - if
we're trying to write a unit, failure is ignored (we'll try again next
time we load the unit), and for other things, we'll report an error
anyway.
Reviewed By: ricklavoie, binliu19
Differential Revision: D14930670
fbshipit-source-id: b6a4efc2b17986492a799d1a77bf35b25c087f7b
| hphp/runtime/base/runtime-option.cpp | diffblobblamehistory | |
| hphp/runtime/base/runtime-option.h | diffblobblamehistory | |
| hphp/runtime/vm/repo.cpp | diffblobblamehistory |