introduce array_multisort1, ..., array_multisort9nightly-2019.08.06
commitaad165a89b578c9af956989f39f6434e65b041ca
authorDaniel Neiter <dneiter@fb.com>
Tue, 6 Aug 2019 01:31:27 +0000 (5 18:31 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 6 Aug 2019 01:35:13 +0000 (5 18:35 -0700)
tree69df37d4810c9ffbefb77973a8575f8ffa02f0ea
parent9085d98120aabfe73b7d39bfcee3279b4f590016
introduce array_multisort1, ..., array_multisort9

Summary:
As we are on the final stages of removing references support from HHVM, we need an alternative solutions for builtin functions, that take optional reference parameters.

array_multisort originally relied on variadic reference parameters, which are no longer supported. For now, make newly added `array_multisortN()` take arguments by reference, but I'll switch them to inout parameters as soon as inout is fully supported for builtins.

Reviewed By: billf

Differential Revision: D16634056

fbshipit-source-id: 6100c6c9a475549633e7aa128760e084196135de
30 files changed:
hphp/hack/hhi/stdlib/builtins_array.hhi
hphp/runtime/ext/array/ext_array.cpp
hphp/runtime/ext/array/ext_array.php
hphp/test/slow/array/array_multisort.php
hphp/test/slow/ext_array/array_multisort.php
hphp/test/slow/ext_array/array_multisort_bug_1.php
hphp/test/slow/global_func/class_meth/dv_arr_hack_arr/container_builtins_warn.php
hphp/test/slow/invalid_argument/1381.php
hphp/test/slow/keyset/builtins.php
hphp/test/slow/lang/ref_args.php
hphp/test/slow/lang/ref_args.php.expectf
hphp/test/slow/variable_argument/22.php
hphp/test/zend/good/Zend/tests/bug52939.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_basic1.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_basic2.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_case.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_incase.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_natural.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_natural_case.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_natural_incase.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation10.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation11.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation4.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation5.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation6.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation7.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation8.php
hphp/test/zend/good/ext/standard/tests/array/array_multisort_variation9.php
hphp/test/zend/good/ext/standard/tests/array/bug24897.php
hphp/test/zend/good/ext/standard/tests/array/bug25359.php