| commit | aab46ec961febe20243b684a4d12e45861bd83a4 | |
| author | Leo Osvald <leoo@fb.com> | |
| Thu, 10 Dec 2020 01:56:44 +0000 (9 17:56 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 10 Dec 2020 01:58:55 +0000 (9 17:58 -0800) | ||
| tree | ae90e8b0a81b8a109bf047f7a44f4921c3c7e9de | treesnapshot (tar.gz zip) |
| parent | 500d9deaa5cbe5ff33d75e61b4e845129bda0dcd | commitdiff |
Migrate rx/pure tests to strict mode, fix broken tests
Summary:
This complicates testing the migration of reactive code to coeffects,
since coeffects very much rely on correct typing. Unfortunately,
partial mode enables subtle bugs due to missing or incorrect types, thus decreasing confidence in the affected unit tests.
A few bugs have been uncovered in reactive tests, which corroborates the above. These were masked due to assume_php and partial mode.
Reviewed By: DavidSnider
Differential Revision: D25420308
fbshipit-source-id: b48210de4b290c0e3ff5cee3904a6e7c6543ac32
Summary:
This complicates testing the migration of reactive code to coeffects,
since coeffects very much rely on correct typing. Unfortunately,
partial mode enables subtle bugs due to missing or incorrect types, thus decreasing confidence in the affected unit tests.
A few bugs have been uncovered in reactive tests, which corroborates the above. These were masked due to assume_php and partial mode.
Reviewed By: DavidSnider
Differential Revision: D25420308
fbshipit-source-id: b48210de4b290c0e3ff5cee3904a6e7c6543ac32
167 files changed: