| commit | a55e4eaafaa6d9ae4a3e31fb410760f7760b4f39 | |
| author | Catherine Gasnier <catg@fb.com> | |
| Mon, 8 Mar 2021 17:14:50 +0000 (8 09:14 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 8 Mar 2021 17:17:33 +0000 (8 09:17 -0800) | ||
| tree | 14d933e5abe71964ac01fd8539636f83f3d1a2a1 | treesnapshot (tar.gz zip) |
| parent | edd48de1dc4869c3b4e1da5bf0f76530868fa5cc | commitdiff |
Enforce Pos_or_decl.t in reasons for decl types
Summary:
This is done by making Typing_reason.t a GADT with a phase type parameter, just like Typing_defs.ty, then redefining `ty` as:
```
<<<<<
type 'ph ty = Reason.t * 'ph ty_
=====
type 'ph ty = 'ph Reason.t * 'ph ty_
>>>>>
```
Reasons with a Pos.t are now `locl Typing_reason.t` while other reasons are just `'phase Typing_reason.t`.
This forbids `decl ty` to use a `locl Reason.t`, while `locl ty` is free to use any reason.
The rest of the changes is just to make the compiler happy.
Reviewed By: ljw1004
Differential Revision: D26516301
fbshipit-source-id: 19a6956e78956e1a750fcc91ec26227483933ceb
Summary:
This is done by making Typing_reason.t a GADT with a phase type parameter, just like Typing_defs.ty, then redefining `ty` as:
```
<<<<<
type 'ph ty = Reason.t * 'ph ty_
=====
type 'ph ty = 'ph Reason.t * 'ph ty_
>>>>>
```
Reasons with a Pos.t are now `locl Typing_reason.t` while other reasons are just `'phase Typing_reason.t`.
This forbids `decl ty` to use a `locl Reason.t`, while `locl ty` is free to use any reason.
The rest of the changes is just to make the compiler happy.
Reviewed By: ljw1004
Differential Revision: D26516301
fbshipit-source-id: 19a6956e78956e1a750fcc91ec26227483933ceb
158 files changed: