| commit | a443a17688477414cb6b6f7cd9559eda493fac53 | |
| author | Eric Bluestein <ericblue@fb.com> | |
| Mon, 6 Apr 2020 22:08:50 +0000 (6 15:08 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 6 Apr 2020 22:12:15 +0000 (6 15:12 -0700) | ||
| tree | af59b53466d6a3f7bd5bc4cc120634edd7bf1d97 | treesnapshot (tar.gz zip) |
| parent | 86acac296edf5ca5802b13288424e1dc3f193386 | commitdiff |
Make breakpoint memoized warning per breakpoint and not per-request
Summary:
Currently the debugger prints a warning when a breakpoint resolves to a memoized location to warn the user that the breakpoint may not hit if the code path is run multiple times (this used to generate a lot of bug reports from people who didn't understand memoization properly). It currently does this when the breakpoint is placed in every request, which is noisy.
This diff changes the warning to be once per breakpoint, rather than once per bp+request ID.
Reviewed By: neilmacintosh
Differential Revision: D20803977
fbshipit-source-id: 4967e3ba296e2dd8d37d5d69124bc0961651b300
Summary:
Currently the debugger prints a warning when a breakpoint resolves to a memoized location to warn the user that the breakpoint may not hit if the code path is run multiple times (this used to generate a lot of bug reports from people who didn't understand memoization properly). It currently does this when the breakpoint is placed in every request, which is noisy.
This diff changes the warning to be once per breakpoint, rather than once per bp+request ID.
Reviewed By: neilmacintosh
Differential Revision: D20803977
fbshipit-source-id: 4967e3ba296e2dd8d37d5d69124bc0961651b300
| hphp/runtime/ext/vsdebug/breakpoint.cpp | diffblobblamehistory | |
| hphp/runtime/ext/vsdebug/breakpoint.h | diffblobblamehistory | |
| hphp/runtime/ext/vsdebug/debugger.cpp | diffblobblamehistory |