| commit | a434618f11dee01c7952aac743c581f0457a02db | |
| author | James Wu <jjwu@fb.com> | |
| Thu, 1 Mar 2018 00:55:46 +0000 (28 16:55 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 1 Mar 2018 01:04:08 +0000 (28 17:04 -0800) | ||
| tree | fc867cc0f9d6857f71dac3afde4a019deaea6133 | treesnapshot (tar.gz zip) |
| parent | d2b881d00fce74bd88866ca3782df34926f9c54b | commitdiff |
Make reading from array with [] an error in most contexts
Summary:
$y = $x[] is banned. This adds a runtime error for its usage.
In my tests, $x[] is allowed only in a few contexts:
- In the context of a reference, i.e. &$x[]
- As an argument to a function
- As an lvalue
Reviewed By: oulgen
Differential Revision: D7058363
fbshipit-source-id: ab959b2d66ddb682874847ffa1ff7abcc33f3431
Summary:
$y = $x[] is banned. This adds a runtime error for its usage.
In my tests, $x[] is allowed only in a few contexts:
- In the context of a reference, i.e. &$x[]
- As an argument to a function
- As an lvalue
Reviewed By: oulgen
Differential Revision: D7058363
fbshipit-source-id: ab959b2d66ddb682874847ffa1ff7abcc33f3431
| hphp/hack/src/hhbc/emit_env.ml | diffblobblamehistory | |
| hphp/hack/src/hhbc/emit_expression.ml | diffblobblamehistory | |
| hphp/test/hhcodegen_failing_tests_zend | diffblobblamehistory |