Check for duplicated instances
commita2b00a83fceef2834ce2864f3d1de7cdf1901c53
authorVincent Siles <vsiles@fb.com>
Thu, 18 Jun 2020 14:57:54 +0000 (18 07:57 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 18 Jun 2020 15:11:16 +0000 (18 08:11 -0700)
tree42c3f9c5eac8e3e52030587db17916070966770c
parent05f1c16f606508386348d5962adabce9e50940fc
Check for duplicated instances

Summary:
This check was strangely implemented. After the previous diff cleaning, we
needd to add the check of duplicated instances either locally or in a parent
class

Reviewed By: francesco-zappa-nardelli

Differential Revision: D21905816

fbshipit-source-id: 37f50f85b2d3dde7bae24c2d6dbb7283bcc47125
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/typing/nast_check/pocket_universes_check.ml
hphp/hack/test/pocket_universes/naming/dup_check.bad.php.exp
hphp/hack/test/pocket_universes/naming/dup_instances.bad.php [new file with mode: 0644]
hphp/hack/test/pocket_universes/naming/dup_instances.bad.php.exp [new file with mode: 0644]
hphp/hack/test/pocket_universes/naming/dup_instances.good.php [new file with mode: 0644]
hphp/hack/test/pocket_universes/naming/dup_instances.good.php.exp [new file with mode: 0644]
hphp/hack/test/pocket_universes/naming/dup_parent_type.bad.php.exp
hphp/hack/test/pocket_universes/typing/decl5.bad.php.exp