| commit | a26475491a80359935c326ef17342229cb7a370c | |
| author | Jake Bailey <jakebailey@fb.com> | |
| Fri, 30 Mar 2018 22:45:42 +0000 (30 15:45 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 30 Mar 2018 23:12:38 +0000 (30 16:12 -0700) | ||
| tree | 6a7132ea4080a3c431fccbcdedd83135a9df9782 | treesnapshot (tar.gz zip) |
| parent | 90b622555ffa1db001c481db9cace9ba96c3ec95 | commitdiff |
Type idx invocations in TAST
Summary: Previously, when building a TAST for an invocation of the function `idx`, we left the `idx` identifier implicitly typed. This change annotates the identifier with the type of `idx` at that application (since its type can vary depending on how it is invoked) instead of no type.
Reviewed By: pittsw
Differential Revision: D7439792
fbshipit-source-id: c1d8e3c0451715fa1243388dc1dbddd8e59323d8
Summary: Previously, when building a TAST for an invocation of the function `idx`, we left the `idx` identifier implicitly typed. This change annotates the identifier with the type of `idx` at that application (since its type can vary depending on how it is invoked) instead of no type.
Reviewed By: pittsw
Differential Revision: D7439792
fbshipit-source-id: c1d8e3c0451715fa1243388dc1dbddd8e59323d8
| hphp/hack/src/typing/typing.ml | diffblobblamehistory | |
| hphp/hack/test/integration_ml/test_server_hover.ml | diffblobblamehistory |