| commit | 9f7524d96d638680292b39acd315cfdd669c251f | |
| author | Thomas Jiang <thomasjiang@fb.com> | |
| Mon, 30 Sep 2019 18:58:13 +0000 (30 11:58 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 30 Sep 2019 19:04:53 +0000 (30 12:04 -0700) | ||
| tree | 6e6afd0f17cab99ec2bbd1c06b28ac4a2d29b279 | treesnapshot (tar.gz zip) |
| parent | aebeb1d40b35275e958b21018d2678f11440ec85 | commitdiff |
Move class const check to nast_check
Summary:
Trying to break up naming into separate components - This stack attempts to clean up and move error checks from naming.ml to into nast_check by converting them to nast_visitors. Some of these passes do not require names or calls to the naming table so they could be parser errors - but keeping them consistent until we decide what we want to do with them later.
Move checks of duplicates for class consts, etc to nast_check. Means we also don't have to pass around a hash table all over the place.
Reviewed By: kmeht
Differential Revision: D17531456
fbshipit-source-id: 1825707d3598e9fbf5acb59d9bb056aa8ac00a3d
Summary:
Trying to break up naming into separate components - This stack attempts to clean up and move error checks from naming.ml to into nast_check by converting them to nast_visitors. Some of these passes do not require names or calls to the naming table so they could be parser errors - but keeping them consistent until we decide what we want to do with them later.
Move checks of duplicates for class consts, etc to nast_check. Means we also don't have to pass around a hash table all over the place.
Reviewed By: kmeht
Differential Revision: D17531456
fbshipit-source-id: 1825707d3598e9fbf5acb59d9bb056aa8ac00a3d