| commit | 9e82cc1ee3e1bfe12ff451cfa79a655a6be7d6e0 | |
| author | Mark Williams <mwilliams@fb.com> | |
| Wed, 8 May 2019 13:04:51 +0000 (8 06:04 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 8 May 2019 13:08:16 +0000 (8 06:08 -0700) | ||
| tree | 9468dd0832c91a0b95991f9d33bb206b328ca4f4 | treesnapshot (tar.gz zip) |
| parent | b059e7f468afec7df824914e46891af2831adc19 | commitdiff |
Fix a debug-types-section bug in debug-parser-dwarf
Summary:
With `-fdebug-types-section` enabled, a struct definition may simply
be a reference to a definition in a different type-unit. If we happen
to pick one of those as the canonical definition, it fails because it
looks like an definition (no declaration attribute), but is missing a
size attribute.
Just follow the reference if we find one.
Reviewed By: alexeyt
Differential Revision: D15251592
fbshipit-source-id: b1a2edfcd6625a750f0382f85ce410625960d5b6
Summary:
With `-fdebug-types-section` enabled, a struct definition may simply
be a reference to a definition in a different type-unit. If we happen
to pick one of those as the canonical definition, it fails because it
looks like an definition (no declaration attribute), but is missing a
size attribute.
Just follow the reference if we find one.
Reviewed By: alexeyt
Differential Revision: D15251592
fbshipit-source-id: b1a2edfcd6625a750f0382f85ce410625960d5b6
| hphp/tools/debug-parser/debug-parser-dwarf.cpp | diffblobblamehistory |