| commit | 9d8f06e199181ebb87a6b894ba4c393f244dc670 | |
| author | Steve Cao <shiqicao@fb.com> | |
| Mon, 21 Sep 2020 20:12:01 +0000 (21 13:12 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 21 Sep 2020 20:16:27 +0000 (21 13:16 -0700) | ||
| tree | 27f416cb633c414e6a854a62be8e9f913bdf1a37 | treesnapshot (tar.gz zip) |
| parent | be760680528d3c3ed9160568f0da372dcec2bf2e | commitdiff |
remove lifetime from StateType
Summary:
The lifetime `'src` on `StateType` was added when some concrete state structs needs to embed source text, most state type doesn't require source text. Carrying `'src` forces `SyntaxSmartConstructors` to carry a `'src` as well.
This `'src` can be total hide from `StateType` and add it by any concrete type if it needs it.
Differential Revision: D23806081
fbshipit-source-id: 218d65993925566f423e93b2a797f0e9ee1e3f91
Summary:
The lifetime `'src` on `StateType` was added when some concrete state structs needs to embed source text, most state type doesn't require source text. Carrying `'src` forces `SyntaxSmartConstructors` to carry a `'src` as well.
This `'src` can be total hide from `StateType` and add it by any concrete type if it needs it.
Differential Revision: D23806081
fbshipit-source-id: 218d65993925566f423e93b2a797f0e9ee1e3f91
13 files changed: