| commit | 9c5a5999f97aac83646659629d625c1d8bb5eb1a | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Wed, 10 Feb 2021 23:27:55 +0000 (10 15:27 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 10 Feb 2021 23:30:49 +0000 (10 15:30 -0800) | ||
| tree | 0c482394a20633342fa78f3859a8e0623cb17f2a | treesnapshot (tar.gz zip) |
| parent | 8d4c17acb249596d4322feb8d0d9e619decef2ed | commitdiff |
Eliminate old plain array notices
Summary: D23588960 (https://github.com/facebook/hhvm/commit/28a51932dc5004e489ddedfbda358a77e2bf4057) was a nice simplification of array comparisons, but it pushed vec <= vec through ArrayData::CompareHelper, which was previously only intended to compare PHP arrays. For the most part, this helper compares vecs correctly, but executing it on Hack arrays triggers notices about "plain arrays", which we eliminated about six months ago. Delete these notices.
Reviewed By: colavitam
Differential Revision: D26374829
fbshipit-source-id: 3e5ab5cdd6efd2d4728d55c02fcee23ea7973cd6
Summary: D23588960 (https://github.com/facebook/hhvm/commit/28a51932dc5004e489ddedfbda358a77e2bf4057) was a nice simplification of array comparisons, but it pushed vec <= vec through ArrayData::CompareHelper, which was previously only intended to compare PHP arrays. For the most part, this helper compares vecs correctly, but executing it on Hack arrays triggers notices about "plain arrays", which we eliminated about six months ago. Delete these notices.
Reviewed By: colavitam
Differential Revision: D26374829
fbshipit-source-id: 3e5ab5cdd6efd2d4728d55c02fcee23ea7973cd6
| hphp/runtime/base/array-data.cpp | diffblobblamehistory |