| commit | 9c4f53f27efe44e11d7c60927de5ffb60d053a61 | |
| author | Max Wang <mwang@fb.com> | |
| Wed, 16 Aug 2017 21:14:44 +0000 (16 14:14 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 16 Aug 2017 21:17:26 +0000 (16 14:17 -0700) | ||
| tree | b90e80bc2bfc8730a0ae50520774473303d2ed13 | treesnapshot (tar.gz zip) |
| parent | 20bdad3d87517bc7c1fb10bceb1e10e03924dab2 | commitdiff |
Add SetWithRef{Int,Str} to array vtable
Summary:
Implement them directly instead of via Lval{Int,Str}. This allows us to
add missing index warnings to Lval*() while avoiding spew from a valid
use case.
We were also using Lval*() unconditionally when sometimes we were
supposed to be using Lval*Ref(). Based on a quick audit of the
callsites, this doesn't appear to have caused us to miss any Hack
array compat notices, or Hack array exceptions, in practice.
Reviewed By: alexeyt
Differential Revision: D5587259
fbshipit-source-id: 8365c76c8663ef183a7852cb4389791a792f0f31
Summary:
Implement them directly instead of via Lval{Int,Str}. This allows us to
add missing index warnings to Lval*() while avoiding spew from a valid
use case.
We were also using Lval*() unconditionally when sometimes we were
supposed to be using Lval*Ref(). Based on a quick audit of the
callsites, this doesn't appear to have caused us to miss any Hack
array compat notices, or Hack array exceptions, in practice.
Reviewed By: alexeyt
Differential Revision: D5587259
fbshipit-source-id: 8365c76c8663ef183a7852cb4389791a792f0f31
25 files changed: