| commit | 9ad56200dadf6beb0ce13cab3de44cdcad89ebfd | |
| author | Max Sherman <jonaldislarry@fb.com> | |
| Mon, 20 Jun 2016 18:30:54 +0000 (20 11:30 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Mon, 20 Jun 2016 18:50:57 +0000 (20 11:50 -0700) | ||
| tree | 74c01ff1a2db4054b037caa54d091743d7548197 | treesnapshot (tar.gz zip) |
| parent | 2806205dd985e3c44f002bc18f39ee09ab4c3a47 | commitdiff |
Properly type stack frames as eval or file
Summary:
Xdebug lets us type stack frame elements as 'eval', in addition to 'file', and this is useful for various reasons, for example, we will want to expose this in the UI of Nuclide.
This diff adds logic to walk the whole call stack to find the oldest frame which qualifies as an 'eval' frame, meaning it has no m_name set, but has a parent.
Reviewed By: alexmalyshev
Differential Revision: D3453570
fbshipit-source-id: b50fa733300b4d1aa6d12ef2a7ec20a18beeb405
Summary:
Xdebug lets us type stack frame elements as 'eval', in addition to 'file', and this is useful for various reasons, for example, we will want to expose this in the UI of Nuclide.
This diff adds logic to walk the whole call stack to find the oldest frame which qualifies as an 'eval' frame, meaning it has no m_name set, but has a parent.
Reviewed By: alexmalyshev
Differential Revision: D3453570
fbshipit-source-id: b50fa733300b4d1aa6d12ef2a7ec20a18beeb405
| hphp/runtime/ext/xdebug/xdebug_command.cpp | diffblobblamehistory |