| commit | 9837af2a7057473039da14485156039cefc1c8f2 | |
| author | Eric Bluestein <ericblue@fb.com> | |
| Wed, 30 Jan 2019 20:36:52 +0000 (30 12:36 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 30 Jan 2019 20:50:33 +0000 (30 12:50 -0800) | ||
| tree | c86edab2c4251311b5f165800fb0b88e5e31f98f | treesnapshot (tar.gz zip) |
| parent | d07a4c6037e2fead3eb3e3cb5e0b144e4508ad1b | commitdiff |
HHVM Debugger: Don't break into __toDebugDisplay during VariablesCommand
Summary:
When evaluating scope objects that have a __toDebugDisplay, we should not break into the __toDebugDisplay method (even if it has a breakpoint). This results in spurrious breaks in some cases, and infinite recursion in the case where there's actually a breakpoint in the method.
Breakpoints in this method may be hit during an evaluation call.
Reviewed By: velocityboy
Differential Revision: D13822067
fbshipit-source-id: 754c693f0117e5c1c7a6fea7753516b0e7ec08c1
Summary:
When evaluating scope objects that have a __toDebugDisplay, we should not break into the __toDebugDisplay method (even if it has a breakpoint). This results in spurrious breaks in some cases, and infinite recursion in the case where there's actually a breakpoint in the method.
Breakpoints in this method may be hit during an evaluation call.
Reviewed By: velocityboy
Differential Revision: D13822067
fbshipit-source-id: 754c693f0117e5c1c7a6fea7753516b0e7ec08c1
| hphp/runtime/ext/vsdebug/hook.cpp | diffblobblamehistory | |
| hphp/runtime/ext/vsdebug/variables_command.cpp | diffblobblamehistory |