use accumulate_const_refs for enums and enum classes
commit9629750ab5f33e7e91800372c01bba443cb2dbc6
authorLucian Wischik <ljw@fb.com>
Thu, 22 Apr 2021 01:13:25 +0000 (21 18:13 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 22 Apr 2021 01:15:44 +0000 (21 18:15 -0700)
tree5fae623d4355c609271774e5affa33ad99825d40
parenta30747a072c016589cfc4a8d04ef8e233d3220e6
use accumulate_const_refs for enums and enum classes

Summary:
Previously, const_refs were gathered by a visitor.

With this diff, we port regular-enums and enum-classes over away from that visitor, to using the new (hopefully more efficient) "accumulate_const_refs" mechanism.

Differential Revision: D27808452

fbshipit-source-id: d2d9bb8d0c2b1df0d684bc6cf4a53a838025a97b
hphp/hack/src/decl/direct_decl_smart_constructors.rs
hphp/hack/test/decl/consts_misc2.php.exp
hphp/hack/test/decl/enum_class.php.exp