| commit | 95c5f6d4099bf6068065d9b21cd356353a8c7eaa | |
| author | Edwin Smith <smith@fb.com> | |
| Wed, 29 Nov 2017 19:12:36 +0000 (29 11:12 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 29 Nov 2017 19:17:43 +0000 (29 11:17 -0800) | ||
| tree | b4d994888eb175460fbd96c7ed7be236fb1dead2 | treesnapshot (tar.gz zip) |
| parent | 49a60a7ab2f11d16b6d2575c2357dbef72f3ebc8 | commitdiff |
Fix assert in recordGdbTranslation
Summary:
assert(contains(start) && contains(end)) incorrectly fails when
end is exactly at the end of the code block, since end is exclusive.
Add a new contains(start,end) predicate with the correct logic.
Reviewed By: markw65
Differential Revision: D6427789
fbshipit-source-id: c3e6235db1b660c86ef7189d51a48452b8373b50
Summary:
assert(contains(start) && contains(end)) incorrectly fails when
end is exactly at the end of the code block, since end is exclusive.
Add a new contains(start,end) predicate with the correct logic.
Reviewed By: markw65
Differential Revision: D6427789
fbshipit-source-id: c3e6235db1b660c86ef7189d51a48452b8373b50
| hphp/runtime/vm/jit/tc-record.cpp | diffblobblamehistory | |
| hphp/util/data-block.h | diffblobblamehistory | |
| hphp/util/test/data-block.cpp | [new file with mode: 0644] | blob |