Drop Globals and RecordArray HeaderKinds
commit959f932d72a83aaa4e6469e347fd10a33863da33
authorShaunak Kishore <kshaunak@fb.com>
Wed, 24 Jun 2020 20:44:51 +0000 (24 13:44 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 1 Jul 2020 01:11:23 +0000 (30 18:11 -0700)
tree480509eee17357130dd07180e19573b363514f6b
parent4fa638d645dc9b0a081e08b7177d06d1755ac8e1
Drop Globals and RecordArray HeaderKinds

Summary:
This change should have been a simple deletion, but in order to keep fast dvarray checks working, we need to rearrange kinds a bit. ricklavoie: you get to say "I told you so."

"interesting" pieces of this change are in array-data-inl.h and irlower-type.cpp.

Reviewed By: ricklavoie

Differential Revision: D22180271

fbshipit-source-id: 5a29c945b67f1bfbedd98b13c5a5d759748afabc
17 files changed:
hphp/runtime/base/array-data-inl.h
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/bespoke/logging-array.cpp
hphp/runtime/base/header-kind.h
hphp/runtime/base/heap-collect.cpp
hphp/runtime/base/heap-report.cpp
hphp/runtime/base/heap-scan.h
hphp/runtime/base/memory-manager-defs.h
hphp/runtime/base/memory-manager.cpp
hphp/runtime/base/packed-array.cpp
hphp/runtime/base/perf-mem-event.cpp
hphp/runtime/ext/asio/ext_await-all-wait-handle.cpp
hphp/runtime/ext/objprof/ext_heapgraph.cpp
hphp/runtime/vm/jit/irlower-type.cpp
hphp/runtime/vm/jit/type-inl.h
hphp/runtime/vm/jit/type-specialization.cpp