| commit | 94eed3a39291c0882a436f4426f571b94c24a508 | |
| author | Joel Marcey <joelm@fb.com> | |
| Wed, 13 Nov 2013 02:30:37 +0000 (12 18:30 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Wed, 13 Nov 2013 22:10:36 +0000 (13 14:10 -0800) | ||
| tree | 9303e940c070187cdde96473cae2bdc0b316513e | treesnapshot (tar.gz zip) |
| parent | 2eae7c350dd13552676f050ef6f13a3d24ab3694 | commitdiff |
Fix the flakiness of Pear
WTF PEAR!!?!?!
Well, Pear was out of control running tests in separate process with wildly changing statuseses for a given test depending on the time of day and alignment of the moon. So created a serial option...
We have consistency now. --record and subsequent runs give the same results.
In the future, maybe allow the parallel/serial flag to be set at the command line, but for now just setting this within the framework class itself.
Pear runs much slower this way. Results can't be viewed piecemail (gotta wait until the end of the run). And I will need to fix the test run messages that get printed in the diff/errors/fatals file to extract single test files this way (the message now tells you to run the entire test suite again).
This script is not affecting flib tests.
Reviewed By: @ptarjan
Differential Revision: D1054205
WTF PEAR!!?!?!
Well, Pear was out of control running tests in separate process with wildly changing statuseses for a given test depending on the time of day and alignment of the moon. So created a serial option...
We have consistency now. --record and subsequent runs give the same results.
In the future, maybe allow the parallel/serial flag to be set at the command line, but for now just setting this within the framework class itself.
Pear runs much slower this way. Results can't be viewed piecemail (gotta wait until the end of the run). And I will need to fix the test run messages that get printed in the diff/errors/fatals file to extract single test files this way (the message now tells you to run the entire test suite again).
This script is not affecting flib tests.
Reviewed By: @ptarjan
Differential Revision: D1054205
| hphp/test/frameworks/results/pear.expect | diffblobblamehistory | |
| hphp/test/frameworks/run.php | diffblobblamehistory |