Various message updates in typechecker-side files to support markdown format
commit94992b211d99232cdd8fbd840d800fbeb3494dc1
authorMichael Christensen <michristensen@fb.com>
Tue, 1 Sep 2020 05:09:08 +0000 (31 22:09 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Tue, 1 Sep 2020 05:11:08 +0000 (31 22:11 -0700)
treec9baf81b327e5c83ae8e3a9df97c11a1ed5f5b90
parentdb35c85a92f9288309c46a1c196091511ba47364
Various message updates in typechecker-side files to support markdown format

Summary: Adding code and bold markdown delimiters to existing error messages, to take advantage of new markdown renderer in highlighted error formatter.

Reviewed By: Wilfred

Differential Revision: D23435897

fbshipit-source-id: 2d04b05a0076322cc9f72fc6e4cb94985d67ee9c
106 files changed:
hphp/hack/src/errors/errors.ml
hphp/hack/src/typing/tast_check/enforceable_hint_check.ml
hphp/hack/src/typing/tast_check/rvalue_check.ml
hphp/hack/src/typing/typing_array_access.ml
hphp/hack/src/typing/typing_equality_check.ml
hphp/hack/src/typing/typing_extends.ml
hphp/hack/src/typing/typing_mutability.ml
hphp/hack/test/error_formatting/always_true.php.exp
hphp/hack/test/integration_ml/test_ignore_fixme_hhi.ml
hphp/hack/test/integration_ml/test_mixed_hack_hackpartial.ml
hphp/hack/test/typecheck/abstract_typeconsts/implement_interface_abstract2.php.exp
hphp/hack/test/typecheck/always_true.php.exp
hphp/hack/test/typecheck/array.php.exp
hphp/hack/test/typecheck/as_expression/tconst7.php.exp
hphp/hack/test/typecheck/await_as_an_expression/error/await_as_an_expression_void_return.php.exp
hphp/hack/test/typecheck/concurrent/error/concurrent_use_error.php.exp
hphp/hack/test/typecheck/dynamic_calls/override.php.exp
hphp/hack/test/typecheck/dynamic_calls/override2.php.exp
hphp/hack/test/typecheck/dynamic_calls/override3.php.exp
hphp/hack/test/typecheck/dynamic_calls/override4.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_arraykey_enum_to_bool_bad.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_arraykey_enum_to_enum_converted_to_bool_bad.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_arraykey_enum_to_enum_converted_to_bool_bad.php.like_types.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_arraykey_enum_to_float_args_bad.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_arraykey_enum_to_float_bad.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_enum_to_float_bad.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_int_enum_to_string_bad.php.exp
hphp/hack/test/typecheck/enum/bad/trivial_compare_string_enum_to_int_bad.php.exp
hphp/hack/test/typecheck/generics_restrictions/report_pos/covariance2.php.exp
hphp/hack/test/typecheck/hard_ban/as.php.exp
hphp/hack/test/typecheck/hard_ban/as.php.like_types.exp
hphp/hack/test/typecheck/hh_fixme3.php.exp
hphp/hack/test/typecheck/ignore_error/f.php.exp
hphp/hack/test/typecheck/inout/bad_inout_decl_memoize1.php.exp
hphp/hack/test/typecheck/inout/bad_inout_decl_memoize2.php.exp
hphp/hack/test/typecheck/inout/bad_inout_decl_memoize3.php.exp
hphp/hack/test/typecheck/inout/bad_inout_decl_special_construct.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg1.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg11.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg2.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg3.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg4.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg4.php.like_types.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg5.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg6.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg7.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg8.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg9.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_arg9.php.like_types.exp
hphp/hack/test/typecheck/inout/bad_inout_use_byref.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue1.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue2.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue3.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue4.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue5.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue5.php.like_types.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue6.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue7.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue8.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue9.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_lvalue9.php.like_types.exp
hphp/hack/test/typecheck/inout/bad_inout_use_pipe_var.php.exp
hphp/hack/test/typecheck/inout/bad_inout_use_this.php.exp
hphp/hack/test/typecheck/is_expression/tconst.php.exp
hphp/hack/test/typecheck/is_expression/tconst3.php.exp
hphp/hack/test/typecheck/is_expression/tconst5.php.exp
hphp/hack/test/typecheck/is_expression/tconst7.php.exp
hphp/hack/test/typecheck/lambda/nested_lambda_break.php.exp
hphp/hack/test/typecheck/like_types/like_casts/like_casts_generics.php.exp
hphp/hack/test/typecheck/nested_function_break.php.exp
hphp/hack/test/typecheck/noreturn_usage.php.exp
hphp/hack/test/typecheck/noreturn_usage_2.php.exp
hphp/hack/test/typecheck/noreturn_usage_3.php.exp
hphp/hack/test/typecheck/null_container.php.exp
hphp/hack/test/typecheck/reactive/test_mutable_return5_4.php.exp
hphp/hack/test/typecheck/reified_generics/enforceable_type_const_as.php.exp
hphp/hack/test/typecheck/reified_generics/is_as_generic_passed_as_targs.php.exp
hphp/hack/test/typecheck/reified_generics/is_as_generic_passed_as_targs.php.like_types.exp
hphp/hack/test/typecheck/reified_generics/is_as_generic_simple.php.exp
hphp/hack/test/typecheck/reified_generics/type_constants_across.php.exp
hphp/hack/test/typecheck/reified_generics/type_constants_across.php.like_types.exp
hphp/hack/test/typecheck/reified_generics/type_constants_basic.php.exp
hphp/hack/test/typecheck/reified_generics/type_constants_basic.php.like_types.exp
hphp/hack/test/typecheck/reified_generics/type_constants_multilevel.php.exp
hphp/hack/test/typecheck/reified_generics/type_constants_multilevel.php.like_types.exp
hphp/hack/test/typecheck/reified_generics/type_constants_self_referential.php.exp
hphp/hack/test/typecheck/shape/null_shape_disallows_indexing_for_expression.php.exp
hphp/hack/test/typecheck/shape/nullable_shape_disallows_indexing.php.exp
hphp/hack/test/typecheck/short_circuit_bad.php.exp
hphp/hack/test/typecheck/string_newline.php.exp
hphp/hack/test/typecheck/switch/multiple_defaults.php.exp
hphp/hack/test/typecheck/switch/multiple_errors.php.exp
hphp/hack/test/typecheck/toplevel_break.php.exp
hphp/hack/test/typecheck/trivial_strict_eq.php.exp
hphp/hack/test/typecheck/trivial_strict_eq_newtype.php.exp
hphp/hack/test/typecheck/trivial_strict_eq_nullable.php.exp
hphp/hack/test/typecheck/trivial_strict_eq_typedef.php.exp
hphp/hack/test/typecheck/union/union_polyvariant.php.exp
hphp/hack/test/typecheck/void_usage.php.exp
hphp/hack/test/typecheck/void_usage_3.php.exp
hphp/hack/test/typecheck/void_usage_4.php.exp
hphp/hack/test/typecheck/void_usage_placeholder.php.exp
hphp/hack/test/typecheck/wrong_fixme_format.php.exp
hphp/hack/test/typecheck/xhp/required_attr/override.php.exp
hphp/hack/test/typecheck/xhp/required_attr/override.php.legacy_decl.exp
hphp/hack/test/typecheck/xhp/required_attr/override.php.like_types.exp