| commit | 948ba6498f6afd8d981e8cbd9a30610e80ed0e0a | |
| author | maide <ian@maide.ca> | |
| Sun, 7 Sep 2014 22:35:37 +0000 (7 15:35 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Sun, 7 Sep 2014 23:00:18 +0000 (7 16:00 -0700) | ||
| tree | 3ebd7a782d50078938418487a3d526466dd651a3 | treesnapshot (tar.gz zip) |
| parent | 6c1a4661b5b5c37a7c78a8af99ee7ba8a4fa917d | commitdiff |
Fix GMP tests/crashes
Summary: This should fix some crashes and all bad tests other than 014, and 028.
I marked test 014 as flakey, as it is checking for wrong return values due to a bug in PHP. It appears as though PHP is using the resource number as the factorial rather than the resource's value, giving unpridictable results (depends on how many resources have been used thus far)
Test 028 still fails as gmp_random is not implemented.
Closes https://github.com/facebook/hhvm/pull/3639
Reviewed By: @sgolemon
Differential Revision: D1530781
Summary: This should fix some crashes and all bad tests other than 014, and 028.
I marked test 014 as flakey, as it is checking for wrong return values due to a bug in PHP. It appears as though PHP is using the resource number as the factorial rather than the resource's value, giving unpridictable results (depends on how many resources have been used thus far)
Test 028 still fails as gmp_random is not implemented.
Closes https://github.com/facebook/hhvm/pull/3639
Reviewed By: @sgolemon
Differential Revision: D1530781
95 files changed: