Remove some dead/dying ArrayData stuff
commit9405bbac81909e68a1e8e0456008d225526bf93c
authorJordan DeLong <jdelong@fb.com>
Tue, 11 Mar 2014 22:27:35 +0000 (11 15:27 -0700)
committerSara Golemon <sgolemon@fb.com>
Fri, 14 Mar 2014 04:06:54 +0000 (13 21:06 -0700)
treeec149b04f5ca063874335607c7c8dbf09e6069ff
parent3b6fc333730372fdddb5a619d976413a9328a9ec
Remove some dead/dying ArrayData stuff

Several constructors were never called.  m_allocMode was now
stored to but never read from (except for asserts).  destroy() was
called in one place.  Several comments were comically out of date
(including talking about virtual functions)---I didn't address all of
that in this diff, though.

Reviewed By: @markw65

Differential Revision: D1215183
hphp/runtime/base/array-data.h
hphp/runtime/base/hphp-array.cpp
hphp/runtime/base/hphp-array.h
hphp/runtime/base/proxy-array.cpp