| commit | 936852a005473293ff2cfba47d062162cf6e18ba | |
| author | Nick Gavalas <njg@fb.com> | |
| Fri, 13 Oct 2017 08:46:26 +0000 (13 01:46 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 13 Oct 2017 09:13:16 +0000 (13 02:13 -0700) | ||
| tree | 0c0bf6db967a7732b45cdb7e50112da692456dbf | treesnapshot (tar.gz zip) |
| parent | 686a287fa991e0fc6aa890868cc8ceabe0f074dd | commitdiff |
make mkdir_p spit out world-readable directories
Summary:
This is super strange. `mkdir_p` uses 0770 and `mkdir_no_fail` uses 0777
for the directory permissions. It appears that D3691691 incorrectly created `mkdir_p`;
before that diff, they would have been 0770. This impacts `flow` compiler: the
recursive artifact output is not world-readable, so stuff written by the compiler
is not readable by the webserver user.
Reviewed By: alexchow
Differential Revision: D6044487
fbshipit-source-id: b6ba1c096c53adc43b51cdd45e91063ee5f9ea93
Summary:
This is super strange. `mkdir_p` uses 0770 and `mkdir_no_fail` uses 0777
for the directory permissions. It appears that D3691691 incorrectly created `mkdir_p`;
before that diff, they would have been 0770. This impacts `flow` compiler: the
recursive artifact output is not world-readable, so stuff written by the compiler
is not readable by the webserver user.
Reviewed By: alexchow
Differential Revision: D6044487
fbshipit-source-id: b6ba1c096c53adc43b51cdd45e91063ee5f9ea93
| hphp/hack/src/utils/disk/realDisk.ml | diffblobblamehistory |