| commit | 9282d9cbf12c050fae6a81b915eccec84f71a9a2 | |
| author | Julia Pitts <jupi@fb.com> | |
| Wed, 10 Jul 2019 21:26:37 +0000 (10 14:26 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 10 Jul 2019 21:30:34 +0000 (10 14:30 -0700) | ||
| tree | fe326ebe2aac4cfd43343d658556835c5dc5474a | treesnapshot (tar.gz zip) |
| parent | a907c28806486a201ee612339898875573639eee | commitdiff |
Typecheck hierarchy and common tests.
Summary: First: I apologize. It's not possible to typecheck these tests without rearchitecting them (it was only possible with the saved state tests because I was dealing with concrete classes, not classes intended to be used as mix-ins), and rearchitecting them involves rearchitecting everything that uses them, so this change ended up being gigantic and I don't think there's actually a way to even split it up, other than having one diff for rearchitecting and one for adding type annotations, but adding the type annotations was vital for doing the rearchitecting successfully, so here we are.
Reviewed By: arxanas
Differential Revision: D16156292
fbshipit-source-id: 38d7bda557a2815907de8bdb6bc5c38bbbb29da3
Summary: First: I apologize. It's not possible to typecheck these tests without rearchitecting them (it was only possible with the saved state tests because I was dealing with concrete classes, not classes intended to be used as mix-ins), and rearchitecting them involves rearchitecting everything that uses them, so this change ended up being gigantic and I don't think there's actually a way to even split it up, other than having one diff for rearchitecting and one for adding type annotations, but adding the type annotations was vital for doing the rearchitecting successfully, so here we are.
Reviewed By: arxanas
Differential Revision: D16156292
fbshipit-source-id: 38d7bda557a2815907de8bdb6bc5c38bbbb29da3