| commit | 925dfdcad563c32b9b6e1019efe5f54cd615a40a | |
| author | Wilfred Hughes <wilfred@fb.com> | |
| Thu, 3 Feb 2022 18:43:57 +0000 (3 10:43 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 3 Feb 2022 18:47:14 +0000 (3 10:47 -0800) | ||
| tree | 9aac5074ecfc3ce432967976e5e14689f596a75b | treesnapshot (tar.gz zip) |
| parent | a165da218b8c2a50edab888885a9f10d29f5d741 | commitdiff |
Autocomplete enum values when calling functions
Summary:
When offering code completion for an
```
// Offer FooEnum::X, FooEnum::Y, etc.
takes_foo_enum(|);
// Offer FooEnum::X, FooEnum::Y, etc but not FooEnum::values().
takes_foo_enum(FooEnum::|);
// Offer FooEnum::X, FooEnum::Y, etc.
takes_foo_enum(takes_generic_inferred_to_foo(|));
```
Reviewed By: vsiles
Differential Revision: D33116602
fbshipit-source-id: 79332c0de3a23ee08cda49f0949458a0fd014062
Summary:
When offering code completion for an
```
// Offer FooEnum::X, FooEnum::Y, etc.
takes_foo_enum(|);
// Offer FooEnum::X, FooEnum::Y, etc but not FooEnum::values().
takes_foo_enum(FooEnum::|);
// Offer FooEnum::X, FooEnum::Y, etc.
takes_foo_enum(takes_generic_inferred_to_foo(|));
```
Reviewed By: vsiles
Differential Revision: D33116602
fbshipit-source-id: 79332c0de3a23ee08cda49f0949458a0fd014062
| hphp/hack/src/server/autocompleteService.ml | diffblobblamehistory | |
| hphp/hack/test/autocomplete/enum_fun_arg.php | [new file with mode: 0644] | blob |
| hphp/hack/test/autocomplete/enum_fun_arg.php.exp | [new file with mode: 0644] | blob |
| hphp/hack/test/autocomplete/enum_value_fun_arg.php | [new file with mode: 0644] | blob |
| hphp/hack/test/autocomplete/enum_value_fun_arg.php.exp | [new file with mode: 0644] | blob |
| hphp/hack/test/autocomplete/generic_fun_enum_arg.php | [new file with mode: 0644] | blob |
| hphp/hack/test/autocomplete/generic_fun_enum_arg.php.exp | [new file with mode: 0644] | blob |