| commit | 91c6e93de67e233a0df9866fdea033a567932c5e | |
| author | Edwin Smith <smith@fb.com> | |
| Thu, 22 Dec 2016 16:57:04 +0000 (22 08:57 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 22 Dec 2016 16:58:31 +0000 (22 08:58 -0800) | ||
| tree | fb6f385db02764af7a8bf501aa7768c6227fce89 | treesnapshot (tar.gz zip) |
| parent | e259cd807abec532635c225f4a042527c10b184d | commitdiff |
Iterate in address order, avoid sorting PtrMap
Summary:
Before a collection starts, we initialize a PtrMap with all
the ranges of heap objects, then sort it, which can be expensive
since PtrMap can be large (>1M entries). However, most of the
entries in PtrMap come from slabs, so if we sort slabs (and big
objects) first, then iterate, we can build PtrMap in address order.
Reviewed By: kodafb
Differential Revision: D4348514
fbshipit-source-id: e2e21321e1e1508a72af26df6526ebac536a272f
Summary:
Before a collection starts, we initialize a PtrMap with all
the ranges of heap objects, then sort it, which can be expensive
since PtrMap can be large (>1M entries). However, most of the
entries in PtrMap come from slabs, so if we sort slabs (and big
objects) first, then iterate, we can build PtrMap in address order.
Reviewed By: kodafb
Differential Revision: D4348514
fbshipit-source-id: e2e21321e1e1508a72af26df6526ebac536a272f
| hphp/runtime/base/heap-collect.cpp | diffblobblamehistory | |
| hphp/runtime/base/memory-manager-defs.h | diffblobblamehistory | |
| hphp/runtime/base/memory-manager.cpp | diffblobblamehistory |