| commit | 90ff20f19992a5a4ab1d9bbfa25db48074216e33 | |
| author | Pranjal Raihan <praihan@meta.com> | |
| Mon, 3 Oct 2022 18:54:59 +0000 (3 11:54 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 3 Oct 2022 18:54:59 +0000 (3 11:54 -0700) | ||
| tree | c0e8ed6cda72f336ff9ead349e0fe5566102aa67 | treesnapshot (tar.gz zip) |
| parent | 6cc93f7f2c4fbb9a1fe813664c67d5c8b272500f | commitdiff |
Do not swallow exceptions from onStartServing
Summary: Like `onStopRequested`, we should be crashing the service if there is an exception in `onStartServing`. Otherwise, the service handler could be left in some undefined state and potentially crash during an RPC instead.
Reviewed By: ycking21
Differential Revision: D39981890
fbshipit-source-id: 18c90bc533e610e1ba80e519b6e084866ca3c22e
Summary: Like `onStopRequested`, we should be crashing the service if there is an exception in `onStartServing`. Otherwise, the service handler could be left in some undefined state and potentially crash during an RPC instead.
Reviewed By: ycking21
Differential Revision: D39981890
fbshipit-source-id: 18c90bc533e610e1ba80e519b6e084866ca3c22e
| third-party/thrift/src/thrift/lib/cpp2/server/ThriftServer.cpp | diffblobblamehistory |