fix lint in oxidized
commit90d29b74bf6cb2f4a7f7cc3b2aacb5652560e5bc
authorEdwin Smith <smith@fb.com>
Fri, 11 Feb 2022 15:35:47 +0000 (11 07:35 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 11 Feb 2022 16:13:34 +0000 (11 08:13 -0800)
treee17a13cff4388856df2c1a728c31f2ce73bf9aef
parent2d7e6088057bff655a8ae3f4ccb9b04d06142e03
fix lint in oxidized

Summary:
* added SavedEnv to the list of special cases in hh_oxidize to not derive Hash/Eq,
etc, which allowed removing a bunch of handwritten trait impls that just assert.
* assert!(false, message) -> panic!(message)
* impl Into -> From
* don't import PosImpl::* wildcard
* assert_eq!(x, bool) -> assert!(x or !x)

Differential Revision: D34106751

fbshipit-source-id: 6a56ba255f9e49c6cdad39495f75ab37e17e5c9b
12 files changed:
hphp/hack/src/hh_oxidize/convert_type_decl.ml
hphp/hack/src/oxidized/aast_visitor/mod.rs
hphp/hack/src/oxidized/gen/tast.rs
hphp/hack/src/oxidized/manual/aast_impl.rs
hphp/hack/src/oxidized/manual/ast_defs_impl.rs
hphp/hack/src/oxidized/manual/errors_impl.rs
hphp/hack/src/oxidized/manual/global_options_impl.rs
hphp/hack/src/oxidized/manual/pos.rs
hphp/hack/src/oxidized/manual/relative_path.rs
hphp/hack/src/oxidized/manual/shape_map.rs
hphp/hack/src/oxidized/manual/t_shape_map.rs
hphp/hack/src/oxidized_by_ref/gen/tast.rs