prepare to migrate Eval.NumReservedSlabs to Eval.NumReservedMBForSlabs
commit904527df0a1a86c5db1b4cacfcbe6cb4f7464fc7
authorBin Liu <binliu@fb.com>
Mon, 8 Aug 2022 20:10:22 +0000 (8 13:10 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 8 Aug 2022 20:10:22 +0000 (8 13:10 -0700)
treeddccf780787fbe6e722f4c77e99cf5dad99a2f88
parent819cdce028bb40cb73202c4a9e0c402e89683cac
prepare to migrate Eval.NumReservedSlabs to Eval.NumReservedMBForSlabs

Summary:
Per suggestion from edwinsmith, we want an option that is independent of slab size.

This diff intends to provide a path for migration without much need for synchronization between releases and config updates. The old Eval.NumReservedSlabs still assumes 2M slabs and will be superceded by Eval.NumReservedMBForSlabs. When the new option is set to nonzero, we ignore the old option.

Reviewed By: edwinsmith

Differential Revision: D38505728

fbshipit-source-id: 76b7666dbc042ca05b089557c9cf57e5ab4b0e34
hphp/runtime/base/program-functions.cpp
hphp/runtime/base/runtime-option.h