Fixes and cleanup for isset() on collections
commit8fbc7a19fe6961aee65834bfbe7d48b5dffe1559
authorDrew Paroski <andrewparoski@fb.com>
Mon, 3 Feb 2014 22:57:13 +0000 (3 14:57 -0800)
committerSara Golemon <sgolemon@fb.com>
Thu, 6 Feb 2014 19:36:11 +0000 (6 11:36 -0800)
tree0f5e5de7f8e8d57e21d1dc4e3d77f3631e31b818
parentbfbb498f58d04435976c6f84203494bfa83f5131
Fixes and cleanup for isset() on collections

This diff fixes multi-level isset (ex. "isset($x[0][1])") to behave as
intended for collections, and it also cleans up a few things and removes
some dead code.

Reviewed By: @elgenie

Differential Revision: D1156660
hphp/runtime/base/type-array.h
hphp/runtime/base/type-variant.cpp
hphp/runtime/base/type-variant.h
hphp/runtime/base/types.h
hphp/runtime/ext/ext_collections.cpp
hphp/runtime/ext/ext_collections.h
hphp/runtime/vm/member-operations.h
hphp/test/slow/collection_classes/collection-isset.php [new file with mode: 0644]
hphp/test/slow/collection_classes/collection-isset.php.expect [new file with mode: 0644]