| commit | 8f7a8d709d3cc3f751476b5287b172f5d04e765a | |
| author | Dwayne Reeves <dreeves@fb.com> | |
| Thu, 3 Nov 2016 16:33:41 +0000 (3 09:33 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Thu, 3 Nov 2016 16:54:55 +0000 (3 09:54 -0700) | ||
| tree | f0b8835dd7a3904f2deb5e24eccceb12dfbd3a34 | treesnapshot (tar.gz zip) |
| parent | 2deffa0543d4f2c26cb4aa9b441ad1f9207f6644 | commitdiff |
Typecheck Extends Dependencies when loading from a saved state
Summary:
Saved state is supposed to get all the dependencies for files that have changed. We utilized `Typing_deps.get_bazooka` to get these dependencies. Unfortunately there are other dependencies not included in this set namely all the extends dependencies. If you look at `Decl_compare.get_all_dependencies` you see there is this additional call to `Decl_compare.get_extend_deps`. Since these dependencies were not included saved state might not report all errors during initialization.
I updated the path in our saved state to include this path. I couldn't figure out a simple repro but this seems like it should be correct.
Reviewed By: oulgen
Differential Revision: D4122299
fbshipit-source-id: cdad0970ccdb6a81b56659b3f28bddd891fa1b35
Summary:
Saved state is supposed to get all the dependencies for files that have changed. We utilized `Typing_deps.get_bazooka` to get these dependencies. Unfortunately there are other dependencies not included in this set namely all the extends dependencies. If you look at `Decl_compare.get_all_dependencies` you see there is this additional call to `Decl_compare.get_extend_deps`. Since these dependencies were not included saved state might not report all errors during initialization.
I updated the path in our saved state to include this path. I couldn't figure out a simple repro but this seems like it should be correct.
Reviewed By: oulgen
Differential Revision: D4122299
fbshipit-source-id: cdad0970ccdb6a81b56659b3f28bddd891fa1b35
| hphp/hack/src/server/serverInit.ml | diffblobblamehistory |