Fix potential segfault in ICUs error handling
commit8f13660801e030b252029db4d2eee67d5cc9a253
authorTim Siebels <tim_siebels_aurich@yahoo.de>
Fri, 25 Jul 2014 06:05:08 +0000 (24 23:05 -0700)
committerfacebook-github-bot <githubbot@fb.com>
Fri, 25 Jul 2014 06:30:21 +0000 (24 23:30 -0700)
tree9e1419d6e9f13a3a446644201c6430c5c42bff97
parent9d3a3c0611f6a0f8d1ee9746fd461e1fea14b8b0
Fix potential segfault in ICUs error handling

Summary: `vsnprintf` returns the size of the string regardless of the buffer size.

Fixes #3118

Closes https://github.com/facebook/hhvm/pull/3247

Reviewed By: ptarjan, joelm

Differential Revision: D1447245

Pulled By: svcscm
hphp/runtime/ext/icu/icu.cpp
hphp/test/slow/ext_icu/error_segfault.php [new file with mode: 0644]
hphp/test/slow/ext_icu/error_segfault.php.expect [new file with mode: 0644]