deprecate coroutine
commit8e40f4a7e437e4347c3f93076c258237749d7dee
authorSteve Cao <shiqicao@fb.com>
Mon, 17 Aug 2020 06:53:39 +0000 (16 23:53 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 17 Aug 2020 06:55:53 +0000 (16 23:55 -0700)
tree0f134260640cade6fc1fb075b8ea89e1aa982075
parent9df9121e79b07e05d41746c0fbec2568e8d99ddf
deprecate coroutine

Summary:
- remove coroutine support from aast
- remove coroutine smart constructor
- replace ocaml_coroutine_positioned_parser by ocaml_positioned_parser
- update tests

Reviewed By: Wilfred

Differential Revision: D22253586

fbshipit-source-id: fa8cc69f12a51455864e6e7e15efe4d39f013099
108 files changed:
hphp/hack/Cargo.lock
hphp/hack/src/annotated_ast/aast_defs.ml
hphp/hack/src/decl/decl_hint.ml
hphp/hack/src/decl/direct_decl_smart_constructors.rs
hphp/hack/src/generate_full_fidelity_data.ml
hphp/hack/src/hhbc/emit_type_constant.rs
hphp/hack/src/hhbc/emit_type_hint.rs
hphp/hack/src/naming/naming.ml
hphp/hack/src/oxidized/aast_visitor/node_impl_gen.rs
hphp/hack/src/oxidized/aast_visitor/node_mut_impl_gen.rs
hphp/hack/src/oxidized/gen/aast_defs.rs
hphp/hack/src/oxidized_by_rc/gen/aast_defs.rs
hphp/hack/src/oxidized_by_ref/gen/aast_defs.rs
hphp/hack/src/parser/aast_parser.rs
hphp/hack/src/parser/api/cargo/coroutine_parser_leak_tree/Cargo.toml [deleted file]
hphp/hack/src/parser/api/cargo/ocaml_positioned_parser/Cargo.toml [new file with mode: 0644]
hphp/hack/src/parser/api/cargo/positioned_coroutine_parser/Cargo.toml [deleted file]
hphp/hack/src/parser/api/coroutine_parser_leak_tree.rs [deleted file]
hphp/hack/src/parser/api/ocaml_positioned_parser.rs [new file with mode: 0644]
hphp/hack/src/parser/api/positioned_coroutine_parser.rs [deleted file]
hphp/hack/src/parser/api/positioned_parser.rs
hphp/hack/src/parser/cargo/aast_parser/Cargo.toml
hphp/hack/src/parser/cargo/ocaml_positioned_parser_ffi/Cargo.toml [moved from hphp/hack/src/parser/cargo/coroutine_parser_leak_tree_ffi/Cargo.toml with 59% similarity]
hphp/hack/src/parser/cargo/ocaml_syntax/Cargo.toml [moved from hphp/hack/src/parser/cargo/coroutine_smart_constructors/Cargo.toml with 51% similarity]
hphp/hack/src/parser/cargo/positioned_coroutine_parser_ffi/Cargo.toml [deleted file]
hphp/hack/src/parser/cargo/rewriter/Cargo.toml [deleted file]
hphp/hack/src/parser/core/declaration_parser.rs
hphp/hack/src/parser/core/expression_parser.rs
hphp/hack/src/parser/core/statement_parser.rs
hphp/hack/src/parser/core/type_parser.rs
hphp/hack/src/parser/coroutine/Cargo.toml [deleted file]
hphp/hack/src/parser/coroutine/cargo/coroutine_lowerer/Cargo.toml [deleted file]
hphp/hack/src/parser/coroutine/cargo/rust_coroutine/Cargo.toml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_closure_generator.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_context.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_lowerer.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_lowerer.mli [deleted file]
hphp/hack/src/parser/coroutine/coroutine_lowerer.rs [deleted file]
hphp/hack/src/parser/coroutine/coroutine_method_lowerer.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_state_machine_data.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_state_machine_generator.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_suspend_rewriter.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_suspend_rewriter.mli [deleted file]
hphp/hack/src/parser/coroutine/coroutine_syntax.ml [deleted file]
hphp/hack/src/parser/coroutine/coroutine_syntax.rs [deleted file]
hphp/hack/src/parser/coroutine/coroutine_type_lowerer.ml [deleted file]
hphp/hack/src/parser/coroutine/dune [deleted file]
hphp/hack/src/parser/coroutine_parser_leak_tree_ffi.rs [deleted file]
hphp/hack/src/parser/coroutine_smart_constructors.rs [deleted file]
hphp/hack/src/parser/dune
hphp/hack/src/parser/ffi/Cargo.toml
hphp/hack/src/parser/ffi/lib.rs
hphp/hack/src/parser/ffi/rust_parser_ffi.ml
hphp/hack/src/parser/full_fidelity_ast.ml
hphp/hack/src/parser/full_fidelity_ast.mli
hphp/hack/src/parser/full_fidelity_ast_types.ml [deleted file]
hphp/hack/src/parser/full_fidelity_positioned_syntax.ml
hphp/hack/src/parser/full_fidelity_syntax.ml
hphp/hack/src/parser/full_fidelity_token_kind.ml
hphp/hack/src/parser/js/full_fidelity_schema.json
hphp/hack/src/parser/lowerer/lowerer.rs
hphp/hack/src/parser/lowerer/modifier.rs
hphp/hack/src/parser/ocaml_context_state.rs [moved from hphp/hack/src/parser/ocaml_coroutine_state.rs with 50% similarity]
hphp/hack/src/parser/ocaml_positioned_parser_ffi.rs [moved from hphp/hack/src/parser/positioned_coroutine_parser_ffi.rs with 62% similarity]
hphp/hack/src/parser/ocaml_syntax.rs
hphp/hack/src/parser/positioned_parser_ffi.rs
hphp/hack/src/parser/positioned_smart_constructors.rs [moved from hphp/hack/src/parser/coroutine_smart_constructors_generated.rs with 50% similarity]
hphp/hack/src/parser/ppl/cargo/ppl_class_rewriter/Cargo.toml [deleted file]
hphp/hack/src/parser/ppl/cargo/ppl_class_rewriter_ffi/Cargo.toml [deleted file]
hphp/hack/src/parser/ppl/dune [deleted file]
hphp/hack/src/parser/ppl/ppl_class_rewriter.ml [deleted file]
hphp/hack/src/parser/ppl/ppl_class_rewriter.mli [deleted file]
hphp/hack/src/parser/ppl/ppl_class_rewriter_ffi.ml [deleted file]
hphp/hack/src/parser/ppl/ppl_rewriter_syntax.ml [deleted file]
hphp/hack/src/parser/ppl/rust_ppl_class_rewriter.rs [deleted file]
hphp/hack/src/parser/ppl/rust_ppl_class_rewriter_ffi.rs [deleted file]
hphp/hack/src/parser/rewriter.rs [deleted file]
hphp/hack/src/parser/rust_parser_errors.rs
hphp/hack/src/parser/schema/full_fidelity_schema.ml
hphp/hack/src/parser/schema/token_schema_definition.ml
hphp/hack/src/parser/smart_constructors/coroutine_smart_constructor.ml [deleted file]
hphp/hack/src/parser/syntax.rs
hphp/hack/src/parser/syntax_sig.ml
hphp/hack/src/parser/token_kind.rs
hphp/hack/src/server/serverExtractStandalone.ml
hphp/hack/src/typing/tast_check/instantiability_check.ml
hphp/hack/src/typing/tast_check/type_params_arity_check.ml
hphp/hack/src/typing/typing_check_decls.ml
hphp/hack/test/full_fidelity/cases/invalid_modifiers_const.php
hphp/hack/test/full_fidelity/cases/invalid_modifiers_const.php.errors.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_const.php.json.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_function.php
hphp/hack/test/full_fidelity/cases/invalid_modifiers_function.php.json.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_method.php
hphp/hack/test/full_fidelity/cases/invalid_modifiers_method.php.errors.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_method.php.json.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_property.php
hphp/hack/test/full_fidelity/cases/invalid_modifiers_property.php.errors.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_property.php.json.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_trait_use_alias_item.php.errors.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_trait_use_alias_item.php.json.exp
hphp/hack/test/full_fidelity/cases/invalid_modifiers_type_const.php.errors.exp [copied from hphp/hack/test/full_fidelity/cases/invalid_modifiers_property.php.errors.exp with 56% similarity]
hphp/hack/test/full_fidelity/cases/invalid_modifiers_type_const.php.json.exp
hphp/hack/test/hackfmt/tests/suspend.php [deleted file]
hphp/hack/test/tast/array_map.php.exp
hphp/hack/test/tast/lambda_contextual.php.exp
hphp/hack/test/tast/reactive.php.exp
hphp/hack/test/tast/singleton_unresolved_function_call.php.exp