| commit | 8e06958af1bec91924fe2b6c765471ab10af339e | |
| author | Jake Bailey <jakebailey@meta.com> | |
| Thu, 17 Nov 2022 17:43:41 +0000 (17 09:43 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 17 Nov 2022 17:43:41 +0000 (17 09:43 -0800) | ||
| tree | 09638137f6a702fd175b4c6afb82b8f1f3227d74 | treesnapshot (tar.gz zip) |
| parent | 877a24312a7a821605bfe4ba79b5f8d33635d0a0 | commitdiff |
Shallow classes heap is nonevictable
Summary: For correctness in incremental typechecking, it's important that we not evict shallow classes. The OCaml heap [is not evictable](https://www.internalfb.com/code/fbsource/[6d4c7ff60206]/fbcode/hphp/hack/src/decl/shallow_classes_heap.ml?lines=24) for this reason.
Reviewed By: shayne-fletcher
Differential Revision: D41364267
fbshipit-source-id: 2a5ac82fa7ba3ccb4b440ba4a5521bbb379328ce
Summary: For correctness in incremental typechecking, it's important that we not evict shallow classes. The OCaml heap [is not evictable](https://www.internalfb.com/code/fbsource/[6d4c7ff60206]/fbcode/hphp/hack/src/decl/shallow_classes_heap.ml?lines=24) for this reason.
Reviewed By: shayne-fletcher
Differential Revision: D41364267
fbshipit-source-id: 2a5ac82fa7ba3ccb4b440ba4a5521bbb379328ce
| hphp/hack/src/providers/hackrs_provider_backend/hackrs_provider_backend.rs | diffblobblamehistory |