Remove PrivacyPolicy covariance hack and allow PrivacyPolicy<this>
commit8cedfc6582a981dece24d9c53d0777d1d0d1a7f9
authorJeff Hemphill <jhemphill@fb.com>
Fri, 9 Jan 2015 22:40:20 +0000 (9 14:40 -0800)
committerhhvm-bot <hhvm-bot@fb.com>
Fri, 9 Jan 2015 23:00:41 +0000 (9 15:00 -0800)
tree3db439c38bdbd89ef0b84afd2d68d7ee3e03857d
parentd805b147227d8ed647eaea9558946bc3e6599da7
Remove PrivacyPolicy covariance hack and allow PrivacyPolicy<this>

Summary: So far my experience with `this` in generics has been very good - I'm not sure why we're still gating it in generics, since Hack seems to have no trouble handling it.

Reviewed By: @elgenie

Differential Revision: D1756811
hphp/hack/src/naming/naming.ml
hphp/hack/src/naming/naming_special_names.ml
hphp/hack/src/typing/typing_subtype.ml
hphp/hack/test/typecheck/iface_require_extends4.php
hphp/hack/test/typecheck/this_privacypolicybase1.php