Public Git Hosting - hiphop-php.git/commit

commit	8cd91fd8278faa4f21238da90df171cdb0e4ba21
author	Wei Luo <vluo@fb.com>
	Tue, 4 Feb 2014 01:34:08 +0000 (3 17:34 -0800)
committer	Sara Golemon <sgolemon@fb.com>
	Thu, 6 Feb 2014 19:27:58 +0000 (6 11:27 -0800)
tree	7908a865ec7590fec5580c3509f9895390dd1d28	tree \| snapshot (tar.gz zip)
parent	a7f3e18c51050354d622e58ecb49fe945ddcb8e8	commit \| diff

fix behaviour diff in date_sunrise and date_sunset

1.debug hhvm using gdb
2.compare with zend php
3.make the bug as a unitest

Reviewed By: @ptarjan

Differential Revision: D1126698

32 files changed:

RSS Atom

hphp/runtime/base/datetime.cpp		diff \| blob \| blame \| history
hphp/runtime/ext/ext_datetime.cpp		diff \| blob \| blame \| history
hphp/runtime/ext/ext_datetime.h		diff \| blob \| blame \| history
hphp/system/idl/datetime.idl.json		diff \| blob \| blame \| history
hphp/test/slow/ext_date/date_sunrise_test.php	[new file with mode: 0644]	blob
hphp/test/slow/ext_date/date_sunrise_test.php.expect	[new file with mode: 0644]	blob
hphp/test/slow/ext_date/date_sunset_test.php	[new file with mode: 0644]	blob
hphp/test/slow/ext_date/date_sunset_test.php.expect	[new file with mode: 0644]	blob
hphp/test/zend/good/ext/date/tests/date_sunrise_variation1.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation1.php with 96% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation1.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation1.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation2.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation2.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation2.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation2.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation3.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation3.php with 96% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation3.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation3.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation4.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation4.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation4.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation4.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation5.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation5.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation5.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation5.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation6.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation6.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunrise_variation6.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunrise_variation6.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation1.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation1.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation1.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation1.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation2.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation2.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation2.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation2.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation3.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation3.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation3.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation3.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation4.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation4.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation4.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation4.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation5.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation5.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation5.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation5.php.expectf with 100% similarity]	blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation6.php	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation6.php with 95% similarity]	diff \| blob \| blame \| history
hphp/test/zend/good/ext/date/tests/date_sunset_variation6.php.expectf	[moved from hphp/test/zend/bad/ext/date/tests/date_sunset_variation6.php.expectf with 100% similarity]	blob \| blame \| history