fix bad todo codenightly-2022.11.07
commit8ba039b0df929dc837482e2635fe83883fc557b9
authorAaron Orenstein <aorenste@meta.com>
Sun, 6 Nov 2022 22:21:09 +0000 (6 14:21 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Sun, 6 Nov 2022 22:21:09 +0000 (6 14:21 -0800)
tree333d00b390d580e33db977fb47f45b4147c03427
parent0268187f893bc0dfdf48856dc8615347ef4a40fe
fix bad todo code

Summary:
For TODO functions instead of making a fake CGetL with a bad variable let's make a dummy call and pass the reason as a string parameter.

This fixes textual so instead of outputting this:
```
n0: *Mixed = load &Array(Keyset(K...tBytesId(17))})))
```

We get this:
```
n0: *Mixed = call todo(null, "Array(K...itBytesId(17))})))")
```

While in there fixed the constant generation code to not stomp on itself.

Reviewed By: artempyanykh

Differential Revision: D41007063

fbshipit-source-id: cb3647535d3d214d7d7f25b70b19a8b846fef2c8
hphp/hack/src/Cargo.lock
hphp/hack/src/hackc/ir/conversions/textual/func.rs
hphp/hack/src/hackc/ir/conversions/textual/lower/func_builder.rs
hphp/hack/src/hackc/ir/ir_core/Cargo.toml
hphp/hack/src/hackc/ir/ir_core/func_builder_ex.rs
hphp/hack/src/hackc/ir/ir_core/instr.rs