Fix inout calls with boxed but unreferenced values
commit8990e16877eabebb27057caf9a3c5eb255704a6a
authorPaul Bissonnette <paulbiss@fb.com>
Thu, 19 Jul 2018 20:14:57 +0000 (19 13:14 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Thu, 19 Jul 2018 20:27:55 +0000 (19 13:27 -0700)
treeb31b995a6d5ed264233bf9fecb3782c66434c14d
parentdf2433419b2a30dcdef7dd5d863dd32714b65b66
Fix inout calls with boxed but unreferenced values

Summary: Passing these as inout values should be completely fine, the fact that something can be boxed but not referenced is purely an implementation detail.

Reviewed By: swtaarrs

Differential Revision: D8624735

fbshipit-source-id: d48782bdf64dfbbbef8bc69cd95a6ae57fd38a89
hphp/runtime/vm/member-operations.h
hphp/test/one_bit_refcount_failing_slow
hphp/test/slow/inout-refs.php [new file with mode: 0644]
hphp/test/slow/inout-refs.php.expect [new file with mode: 0644]