| commit | 89103200812e3570c4107f6e83c9720f6c305d3e | |
| author | Eric Shrewsberry <eshrews@fb.com> | |
| Wed, 15 Jun 2016 01:04:36 +0000 (14 18:04 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Wed, 15 Jun 2016 01:08:04 +0000 (14 18:08 -0700) | ||
| tree | f5eff24cc5a88e7f5a5b1dd276cca82441d36fde | treesnapshot (tar.gz zip) |
| parent | e217770b457adb252fd90a0c1cb7c1a629c85a00 | commitdiff |
Fix nontermination issue in the full-fidelity parser
Summary:
Colon after a possible binary expression was causing an infinite loop because no progress was being made. Removing this allows the program to terminate with errors instead on the following expression:
$func = (): int ==> 1;
Talked with ericlippert, and decided that colons don't need to belong in this category and that we will explicitly handle ternary operations instead.
Differential Revision: D3429102
fbshipit-source-id: 55f7e09fb348ba5ddf0968795db39593a61d5cfe
Summary:
Colon after a possible binary expression was causing an infinite loop because no progress was being made. Removing this allows the program to terminate with errors instead on the following expression:
$func = (): int ==> 1;
Talked with ericlippert, and decided that colons don't need to belong in this category and that we will explicitly handle ternary operations instead.
Differential Revision: D3429102
fbshipit-source-id: 55f7e09fb348ba5ddf0968795db39593a61d5cfe
| hphp/hack/src/full_fidelity/full_fidelity_operator.ml | diffblobblamehistory |