Refactor env_with_self
commit88f722e5eb83653067b042381cb235e8e91c3735
authorAndrew Kennedy <akenn@fb.com>
Wed, 28 Apr 2021 17:20:07 +0000 (28 10:20 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 28 Apr 2021 17:21:48 +0000 (28 10:21 -0700)
treeab775e30086016ca4aece67b5f0d1560a6ea8142
parente4de89e78d5884d05e07dbe5dfc5d769182b8d84
Refactor env_with_self

Summary: The `env` parameter to `env_with_self` is now dead. This gives an opportunity to clean up: we can move `expand_env` constructor functions into `Typing_defs.ml`, simplify usage, and remove need for cycle through `Typing_utils`.

Reviewed By: vsiles

Differential Revision: D28055223

fbshipit-source-id: 349bb537ff922d61212f22a922757467d319b4fd
17 files changed:
hphp/hack/src/typing/tast_env.ml
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_check_decls.ml
hphp/hack/src/typing/typing_defs.ml
hphp/hack/src/typing/typing_defs.mli
hphp/hack/src/typing/typing_dynamic.ml
hphp/hack/src/typing/typing_equality_check.ml
hphp/hack/src/typing/typing_exts.ml
hphp/hack/src/typing/typing_kinding.ml
hphp/hack/src/typing/typing_memoize.ml
hphp/hack/src/typing/typing_phase.ml
hphp/hack/src/typing/typing_phase.mli
hphp/hack/src/typing/typing_structure.ml
hphp/hack/src/typing/typing_subtype_method.ml
hphp/hack/src/typing/typing_subtype_tconst.ml
hphp/hack/src/typing/typing_toplevel.ml
hphp/hack/src/typing/typing_utils.ml