| commit | 88af886439bb0bfb54dbe766d8112ab56882333e | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Mon, 18 Nov 2013 21:53:19 +0000 (18 13:53 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Thu, 21 Nov 2013 06:07:54 +0000 (20 22:07 -0800) | ||
| tree | 8809479fe1dcd04b6c573f392cc6e7fd6ec343ca | treesnapshot (tar.gz zip) |
| parent | 2373167ba964ef3dc7484b65d6f33c81f944234c | commitdiff |
Combine smart_malloc with the 'size-untracked' freelists
I kept these separate when strings were first moved from the
old SmartAllocatorImpl stuff into here because combining them
increased stores too much. Now that almost all of the heap is going
through the smartMallocSize api, it seems ok to combine them. Perflab
showed stores very slightly up (red only on a few endpoints), d-TLB
misses possibly slightly down, d-cache misses down, cpu time in the
noise.
Reviewed By: @edwinsmith
Differential Revision: D1062598
I kept these separate when strings were first moved from the
old SmartAllocatorImpl stuff into here because combining them
increased stores too much. Now that almost all of the heap is going
through the smartMallocSize api, it seems ok to combine them. Perflab
showed stores very slightly up (red only on a few endpoints), d-TLB
misses possibly slightly down, d-cache misses down, cpu time in the
noise.
Reviewed By: @edwinsmith
Differential Revision: D1062598
| hphp/runtime/base/memory-manager-inl.h | diffblobblamehistory | |
| hphp/runtime/base/memory-manager.cpp | diffblobblamehistory | |
| hphp/runtime/base/memory-manager.h | diffblobblamehistory |