Clean up logging and switch for fixing fuzzy comparisons between Hack arrays and...
commit87750b73909289a4c1ed9ba683df669b69478fcc
authorMike Qian <mqian@fb.com>
Tue, 21 Apr 2020 03:34:17 +0000 (20 20:34 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Tue, 21 Apr 2020 03:38:38 +0000 (20 20:38 -0700)
treebbb99490dba0fc8a6222edf38e2acf5a2a8bc10c
parent8c29f35eb4d4d3f64f9f317001d167f0ede4b3c1
Clean up logging and switch for fixing fuzzy comparisons between Hack arrays and boolean/null

Summary:
The new behavior described in the [HHVM 4.49 release notes][1] for comparing Hack arrays to `true`, `false`, and `null` using the "fuzzy" equality comparison operators (`==`, `!=`) is now effective, and the flags are removed.

[1]: https://hhvm.com/blog/2020/03/18/hhvm-4.49.html

Reviewed By: viratyosin

Differential Revision: D21082493

fbshipit-source-id: c0403baeb1c5d58bf3b61153f276d2e4648cd0aa
25 files changed:
hphp/compiler/analysis/emitter.cpp
hphp/compiler/option.cpp
hphp/hhbbc/main.cpp
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/runtime-option.h
hphp/runtime/base/strings.h
hphp/runtime/base/tv-comparisons.cpp
hphp/runtime/base/unit-cache.cpp
hphp/runtime/vm/jit/irgen-arith.cpp
hphp/runtime/vm/repo-global-data.cpp
hphp/runtime/vm/repo-global-data.h
hphp/test/quick/dict/comparisons.php.expect [moved from hphp/test/quick/dict/comparisons.php.expectf with 99% similarity]
hphp/test/quick/keyset/comparisons.php.expect [moved from hphp/test/quick/keyset/comparisons.php.expectf with 99% similarity]
hphp/test/quick/vec/comparisons.php.expect [moved from hphp/test/quick/vec/comparisons.php.expectf with 98% similarity]
hphp/test/slow/comparisons/all_type_comparison_test.php.expect
hphp/test/slow/hack_arr_compat/cmp-bool-emptybasedeq.php [deleted file]
hphp/test/slow/hack_arr_compat/cmp-bool-emptybasedeq.php.expect [deleted file]
hphp/test/slow/hack_arr_compat/cmp-bool-emptybasedeq.php.hphp_opts [deleted file]
hphp/test/slow/hack_arr_compat/cmp-bool-emptybasedeq.php.opts [deleted file]
hphp/test/slow/hack_arr_compat/cmp-bool-notice.php [deleted file]
hphp/test/slow/hack_arr_compat/cmp-bool-notice.php.expect [deleted file]
hphp/test/slow/hack_arr_compat/cmp-bool.php.expect
hphp/test/slow/hack_arr_compat/cmp-bool.php.hphp_opts [moved from hphp/test/slow/hack_arr_compat/cmp-bool-notice.php.hphp_opts with 82% similarity]
hphp/test/slow/hack_arr_compat/cmp-bool.php.opts [moved from hphp/test/slow/hack_arr_compat/cmp-bool-notice.php.opts with 88% similarity]