Remove side effect from `smember_not_found`
commit8738b57bfd3c212e41478f3cbcc44a11ace1f122
authorMichael Thomas <mjt@fb.com>
Mon, 7 Feb 2022 10:26:11 +0000 (7 02:26 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 7 Feb 2022 10:31:18 +0000 (7 02:31 -0800)
tree91ef1f9cc165cf62fabe72f13be288accbad55c8
parent29e7a631f064bb5c1e439bfba4c0170ffbe77b60
Remove side effect from `smember_not_found`

Summary: Pulls `add_typing_error` side effect out of `smember_not_found` and into the call sites

Reviewed By: vsiles

Differential Revision: D33942251

fbshipit-source-id: 6cf6d3d5147f3df5caf819ae8bed1508874c77f7
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_object_get.ml
hphp/hack/src/typing/typing_object_get.mli
hphp/hack/src/typing/typing_shapes.ml