| commit | 85eb255cfa84f57680f7ea9844ac5ba947cd6589 | |
| author | Roman Malinovskyy <romanmal@fb.com> | |
| Wed, 21 Aug 2019 02:55:50 +0000 (20 19:55 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 21 Aug 2019 02:58:08 +0000 (20 19:58 -0700) | ||
| tree | 8c56908801beacfe38d63c74d9de1e00afa87d13 | treesnapshot (tar.gz zip) |
| parent | 9a66485ddb708160e31f665f31b483f2eafe6241 | commitdiff |
Log total HHAS retrieval time
Summary:
This diff ensures we log total hhas retrieval time no matter whether hhas handler is installed or not.
In particular this diff fixes following problems:
1) If handler is installed but does not invoke `compile` lambda (e.g. gets data from cache) retrieval duration is not logged at all;
2) This also messes up `assemble_hhas` metric. As `statefulLogTime` was not invoked the `t` hasn't been updated since original `startTime`. As a result when `statefulLogTime("assemble_hhas");` is invoked it includes `g_hhas_handler` execution time into `assemble_hhas` metric. This is wrong.
Reviewed By: ricklavoie
Differential Revision: D16926989
fbshipit-source-id: 883e68c83aa740e04df5e3bc8a3457ca58d47c31
Summary:
This diff ensures we log total hhas retrieval time no matter whether hhas handler is installed or not.
In particular this diff fixes following problems:
1) If handler is installed but does not invoke `compile` lambda (e.g. gets data from cache) retrieval duration is not logged at all;
2) This also messes up `assemble_hhas` metric. As `statefulLogTime` was not invoked the `t` hasn't been updated since original `startTime`. As a result when `statefulLogTime("assemble_hhas");` is invoked it includes `g_hhas_handler` execution time into `assemble_hhas` metric. This is wrong.
Reviewed By: ricklavoie
Differential Revision: D16926989
fbshipit-source-id: 883e68c83aa740e04df5e3bc8a3457ca58d47c31
| hphp/runtime/vm/extern-compiler.cpp | diffblobblamehistory |